Normalize duplicate keyboard shortcut bindings on load#665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a keyboard shortcut edge case where duplicate saved bindings can leave a key non-functional or unreliable at runtime.
Problem
Shortcut bindings are loaded from settings without conflict resolution. If two actions end up saved with the same key, ShortcutManager rebuilds multiple QShortcuts for that key. In practice that can make the key behave ambiguously.
One real example was:
That let USB work with its unique binding while LSB appeared broken.
Fix
During ShortcutManager load, normalize duplicate key assignments before shortcuts are rebuilt:
Why this is low risk
Validation