[codex] Add source-attributed KiwiSDR denial messages#3716
Merged
ten9876 merged 2 commits intoJun 22, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
Reintroduces source-attributed KiwiSDR terminal denial handling by mapping additional MSG keys and badp codes to clearer user-facing error messages, and documents the consulted KiwiSDR LGPL-marked source snapshot in project provenance/license docs.
Changes:
- Adds a
badpMessage()helper to provide specific, source-attributedbadpdenial descriptions. - Extends
KiwiSdrClient::handleTextMessage()to handle additional denial/disconnectMSGkeys (wb_only,exclusive_use,inactivity_timeout,password_timeout,kiwi_kick). - Updates
THIRD_PARTY_LICENSESanddocs/kiwisdr-cleanroom-design.mdto record source provenance and scope of use.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| THIRD_PARTY_LICENSES | Adds a KiwiSDR protocol-reference provenance entry (LGPL-marked source snapshot) for denial-message labeling. |
| src/core/KiwiSdrClient.cpp | Implements additional badp labels and new MSG denial/disconnect key handling. |
| docs/kiwisdr-cleanroom-design.md | Documents the consulted KiwiSDR source snapshot and enumerates source-attributed denial message shapes/meanings. |
Comment on lines
+1944
to
+1959
| if (key == QStringLiteral("wb_only")) { | ||
| setState( | ||
| State::Error, | ||
| tr("This KiwiSDR is configured for wideband use only and does " | ||
| "not accept normal receiver connections.")); | ||
| cleanupSockets(); | ||
| return; | ||
| } | ||
| if (key == QStringLiteral("exclusive_use")) { | ||
| setState( | ||
| State::Error, | ||
| tr("This KiwiSDR is locked for exclusive use by another " | ||
| "operation. Try again later or choose another receiver.")); | ||
| cleanupSockets(); | ||
| return; | ||
| } |
ten9876
approved these changes
Jun 22, 2026
ten9876
left a comment
Collaborator
There was a problem hiding this comment.
Approving — the proper "path B" follow-up to #3699, done well, CI now green on all six checks.
Verified against the diff:
- Provenance / Principle IV — handled correctly.
THIRD_PARTY_LICENSESanddocs/kiwisdr-cleanroom-design.mdcite the exact source (jks-prv/Beagle_SDR_GPS, LGPL-2.0-or-later, pinned commitefb38e2b, the specific files consulted) and state plainly that no code was copied/translated/vendored/linked — only protocol facts (badp codes, MSG keys) were extracted. The badp messages are original AetherSDR wording (full user-facing sentences), not the terse C-source strings. Protocol codes are facts, not copyrightable expression — this is the legitimate way to do it, and the doc cleanly separates the original black-box work from this source-attributed exception. - badp=5 reconciled exactly as flagged in #3699 — worded with both the source-derived duplicate-IP meaning and the observed public-access-rejection hint.
- Copilot's "unreachable bare-token handlers" finding is resolved. The parser was refactored into
KiwiSdrProtocol::parseMsgTokens()(emitshasValue=falseflag tokens),handleTextMessagewas rewired to iterate those (thehasValuebranch only gates logging, no skip), sowb_only/exclusive_use/password_timeoutreach their handlers. Covered by a new unit test (MSG wb_only password_timeout inactivity_timeout=15 …→ flags vs key/value asserted,=ignoreddropped). Copilot reviewed a pre-refactor state. - Runtime still treats these as terminal denial states only; unknown keys ignored.
CI green (build/macOS/Windows/CodeQL/analyze/a11y). Thanks @rfoust — clean provenance and a tidy parser refactor.
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reintroduce source-attributed KiwiSDR terminal denial handling for the MSG keys and
badplabels that were intentionally left out of #3699. The follow-up adds provenance inTHIRD_PARTY_LICENSESanddocs/kiwisdr-cleanroom-design.md, cites the consulted LGPL-marked KiwiSDR source snapshot, and keepsbadp=5wording conservative because deployed receivers have returned it for public-access rejection as well as the source-derived duplicate-IP case.Constitution principle honored
Principle IV — the protocol labels come from a documented open-source LGPL reference snapshot, with no KiwiSDR code copied, translated, vendored, or linked into AetherSDR.
Test plan
cmake --build /private/tmp/aethersdr-kiwi-source-attribution-build --target AetherSDR -- -j4)ctest --test-dir /private/tmp/aethersdr-kiwi-source-attribution-build -R '^kiwi_sdr_protocol_test$' --output-on-failure)Checklist
docs/COMMIT-SIGNING.md)AppSettingscalls — use nested-JSON-under-one-key(Principle V)
reverse-engineered from a proprietary binary (Principle IV)
MeterSmoother(AGENTS.md convention)