Added metainfo for AppStream (for Linux)#3673
Conversation
There was a problem hiding this comment.
Thanks for this, Dawid (SP9SKA)! AppStream metadata is a nice quality-of-life addition for Linux software stores, and the PR is well-scoped — just the metainfo file plus its install rule. 73!
I verified the things that tend to break in metainfo PRs, and they all hold up:
- ✅ Component
<id>is correct rDNS and matches the filename (io.github.aethersdr.aethersdr.metainfo.xml). - ✅
<launchable>AetherSDR.desktop</launchable>matches the actual installed desktop file — CMake configuresAetherSDR.desktop.in→ installs asAetherSDR.desktopintoapplications/. - ✅ Both referenced URLs resolve:
docs/assets/screenshot-current.pngandSUPPORT.mdexist in the repo. - ✅ Install
DESTINATION ${CMAKE_INSTALL_DATAROOTDIR}/metainfois the right location. - ✅ All CI green (build, macOS/Windows checks, CodeQL, a11y).
A few non-blocking suggestions for when this gets expanded (you already flagged that it should be):
-
appstreamcli validatewill warn on two missing elements that catch most basic metainfo files:<developer id="...">/<developer_name>— recommended, emitted as a warning.<content_rating type="oars-1.1"/>— required for a Flathub submission (an empty OARS block is valid and means "no objectionable content"). Worth adding now so a future store submission doesn't bounce.
Runningappstreamcli validate(orflatpak run org.freedesktop.appstream-glib validate) locally is a quick way to see the full list.
-
<releases>— you mentioned this; agreed it's a good follow-up once there's a versioned release to point at. -
Minor: a few of the indented blank lines (e.g. lines 3, 6, 8, 22) carry trailing whitespace —
git diff --checkwould flag them. Easy to strip; no impact on functionality.
None of these block the core value here. Nice contribution — thank you!
🤖 aethersdr-agent · cost: $1.5956 · model: claude-opus-4-8
ten9876
left a comment
There was a problem hiding this comment.
Approving — clean, correct, well-scoped. appstreamcli validate passes (only info/pedantic notices), project_license matches the repo (GPL-3.0-or-later), the referenced screenshot/SUPPORT.md exist on main, and the launchable correctly maps the reverse-DNS component id to the installed AetherSDR.desktop. Install lands in share/metainfo within the Linux branch. Nice first contribution — 73 SP9SKA. Filing a consolidated follow-up for the optional polish (OARS content_rating for Flathub, developer/releases elements, screenshot caption + stable URL).
Hello,
I added the AppStream metadata for Linux.
It allows the graphical stores to properly show the AetherSDR, with description and screenshot.
It can be (and should be!) expanded in the future. This is the only basic one.
Here are the links for the reference:
https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#sect-Metadata-GenericComponent
https://www.freedesktop.org/software/appstream/docs/sect-Metadata-Releases.html
https://www.freedesktop.org/software/appstream/docs/sect-Metadata-Application.html
I also added the proper installation in CMakeLists.txt
Thanks!
Dawid Kulas
SP9SKA