Document frameless guidance for popout dialogs#2619
Merged
ten9876 merged 1 commit intoMay 13, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
Adds contributor/agent guidance to ensure new popout windows and dialogs consistently respect the global FramelessWindow setting and follow existing frameless-chrome patterns already used in the GUI code.
Changes:
- Document requirement that new popout windows/tool windows/
QDialogs honorAppSettings("FramelessWindow")by default. - Point contributors at existing frameless helpers (
FramelessWindowTitleBar,FramelessResizer) and theNetworkDiagnosticsDialog::setFramelessModegeometry/visibility pattern. - Add guidance on avoiding constructor-time geometry restore / forced
(0,0)placement and when explicit centering should be documented.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing