Pull request overview

This PR makes the app’s “View → Frameless Window” setting apply consistently to modeless/popout windows by introducing a shared frameless title-bar widget and propagating frameless toggles to already-open popouts.

Changes:

• Added a reusable FramelessWindowTitleBar widget and integrated it into multiple popout dialogs/windows.
• Implemented setFramelessMode(bool) across several popouts and wired MainWindow::setFramelessWindow() to propagate the toggle to active popouts/editors.
• Replaced the FFTW wisdom QProgressDialog with a custom dialog that supports the frameless chrome.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Thanks @rfoust — broad and well-targeted change, and the new FramelessWindowTitleBar helper plus the unified propagation in MainWindow::setFramelessWindow match the existing chrome nicely. Reads fine for behaviour at the popouts I traced; below are a couple of constructive items, mostly aligned with what Copilot flagged.

1. Replacing window flags drops hints — preserve-and-toggle instead (Copilot finding, valid)

All six new setFramelessMode paths plus the two anonymous-namespace helpers in MainWindow.cpp use the same shape:

Qt::WindowFlags flags = Qt::Dialog;       // or Qt::Window
if (on) flags |= Qt::FramelessWindowHint;
setWindowFlags(flags);

This intentionally drops every other flag bit that may have been set (default Qt::WindowTitleHint, Qt::WindowSystemMenuHint, Qt::WindowCloseButtonHint, Qt::WindowMinMaxButtons, anything else the parent or platform applied). The convention already in the tree is preserve-and-toggle:

• MainWindow::setFramelessWindow (src/gui/MainWindow.cpp:10138-10142)
• PanFloatingWindow::setFramelessMode (src/gui/PanFloatingWindow.cpp:76-81)

Qt::WindowFlags flags = windowFlags();
if (on) flags |= Qt::FramelessWindowHint;
else    flags &= ~Qt::FramelessWindowHint;
setWindowFlags(flags);

In practice the symptom you might hit when toggling frameless OFF is a decorated dialog without the close/min/max trio on Windows, since the default Qt::Dialog hints aren't replaced after the first setWindowFlags(Qt::Dialog). Switching the new helpers (AetherDspDialog, RadioSetupDialog, ConnectionPanel, NetworkDiagnosticsDialog, PropDashboardDialog, AetherialAudioStrip, plus the setEditorFramelessMode / setDialogFramelessMode helpers in MainWindow.cpp) to the preserve-and-toggle form keeps the rest of the existing flag bits intact and matches the established codebase pattern.

2. Quindar lookup walks all top-level widgets

In MainWindow::setFramelessWindow:

for (auto* widget : QApplication::topLevelWidgets()) {
    if (widget && widget->objectName() == "quindarToneEditor") {
        setDialogFramelessMode(qobject_cast<QDialog*>(widget), on);
    }
}

This works, but it scans every top-level widget in the app and matches on a string objectName, so any other widget that ever happens to take the same objectName would also get rebuilt. Since StripFinalOutputPanel::showQuindarEditor already has the dialog pointer in scope, an alternative would be to expose a MainWindow::registerQuindarDialog(QDialog*) (cleared via QObject::destroyed), or to keep a QPointer<QDialog> m_quindarDialog set when the editor is created. Same with the editor pointers — they're already members, so this one is the only string-match scan. Minor, but worth tightening.

3. Small things

• framelessWindowEnabled() lives in the anon namespace in MainWindow.cpp but every other touched class re-implements AppSettings::instance().value("FramelessWindow", "True").toString() == "True" inline. If you keep the pattern, fine; otherwise hoisting that into something like AppSettings::instance().framelessWindowEnabled() (or a small helper in a shared header) would deduplicate ~7 copies.
• The if (!(windowFlags() & Qt::FramelessWindowHint)) return {}; guards added to edgesAt() are a nice touch — they prevent the custom 8-axis resize from firing when native decorations are in charge. Good defensive fix to bundle with this.

Nothing blocking — the structural cleanup here is a net win, and the propagation list in MainWindow::setFramelessWindow covers the popouts the PR description calls out. Mainly the flags-replacement issue is worth fixing across the new helpers so this doesn't surprise anyone the next time a dialog adds a custom hint.