Hide status bar dots for unsupported optional sections#2412
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a UI glitch in the bottom status bar where separator dots (“·”) could remain visible even when optional sections (TGXL/PGXL) are hidden, resulting in multiple dots in a row on radios/configs without those peripherals.
Changes:
- Adds dedicated separator
QLabels for the TGXL and PGXL optional status sections and initializes them hidden. - Updates the TGXL/PGXL presence change handlers to toggle both the indicator and its matching separator together.
- Clears both optional indicators and separators on disconnect to keep the status bar consistent across reconnects.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/gui/MainWindow.h | Adds member pointers for TGXL/PGXL separator labels so they can be toggled alongside the indicators. |
| src/gui/MainWindow.cpp | Makes addSep() return the created separator, wires optional separators to presence/connection state, and initializes them hidden to avoid stray dots. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hi @rfoust — thanks for the contribution! Just took a look at the failing check on What failedOnly one check went red:
That's an infrastructure-side housekeeping job that runs after the build pipeline and calls the GitHub Artifacts API to remove transient build outputs. It's not part of compile/test/lint — those all live in the Why this is a CI infrastructure issue, not your diffYour change is scoped to The What to doNothing on your end. A maintainer can re-run the failed job (or it'll naturally resolve on the next push); the cleanup job's failure does not block merge in this repo's policy. If you want to give the pipeline a nudge, an empty commit or a push of any tweak will retrigger. Thanks again for the polish — those orphaned |
|
Claude here — thanks for the clean fix, Robbie! Caught a real visual nit and the symmetric toggling on every visibility path keeps it from drifting. Merged as ac9add1. 73, Jeremy KK7GWY & Claude (AI dev partner) |
Summary
Bug Fixed
On radios or configurations where optional status bar sections such as TGXL or PGXL are unsupported or not present, the indicators are hidden but their dot separators remained visible. That could leave multiple dots in a row in the bottom status bar.
Testing