Cherry-pick #2059: Frameless toggle propagation to floating windows#2067
Merged
ten9876 merged 1 commit intoApr 27, 2026
Merged
Conversation
Originally by @chibondking — propagates View → Frameless Window setting to all popped-out panadapters and applet containers, instead of leaving them with hardcoded Qt::FramelessWindowHint. - PanFloatingWindow / FloatingContainerWindow constructors now read AppSettings["FramelessWindow"] instead of hardcoding the flag. - New setFramelessMode(bool) on both window classes flips the flag at runtime, preserving geometry + visibility. - PanadapterStack::setFramelessMode and ContainerManager::setFramelessMode iterate live floating windows and propagate the toggle. - MainWindow::setFramelessWindow calls into both managers. Resolved one trivial conflict in PanadapterStack.h where the new setFramelessMode declaration overlapped with the saveFloatingState/ restoreFloatingState block from #2065. Closes #2059. Co-Authored-By: CJ Johnson <cj@cedrick.io> Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced Apr 27, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally by @chibondking — propagates View → Frameless Window setting
to all popped-out panadapters and applet containers, instead of leaving
them with hardcoded Qt::FramelessWindowHint.
AppSettings["FramelessWindow"] instead of hardcoding the flag.
runtime, preserving geometry + visibility.
iterate live floating windows and propagate the toggle.
Resolved one trivial conflict in PanadapterStack.h where the new
setFramelessMode declaration overlapped with the saveFloatingState/
restoreFloatingState block from #2065.
Closes #2059.
Co-Authored-By: CJ Johnson cj@cedrick.io
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com