[fix] Handle pipe separator in rigctld protocol (#2048)#2051
Closed
aethersdr-agent[bot] wants to merge 1 commit into
Closed
[fix] Handle pipe separator in rigctld protocol (#2048)#2051aethersdr-agent[bot] wants to merge 1 commit into
aethersdr-agent[bot] wants to merge 1 commit into
Conversation
The rigctld wire protocol uses '|' as a command separator (e.g. "|f" means "get frequency with extended output"). AetherSDR only recognised ';' as a batch separator, so pipe-prefixed commands like "|f" returned RPRT -4 (invalid command). Split on '|' in handleLine(), enable extended response mode for pipe-separated commands, and join responses with '|' — matching standard rigctld behaviour that tools like Not1MM expect. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2 tasks
Collaborator
|
Closing as part of a maintenance cleanup of stale AetherClaude PRs. The underlying issue this PR addressed remains tracked separately, and we plan to revisit it later. |
2 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2048
What was changed
[fix] Handle pipe separator in rigctld protocol (#2048)
Files modified
src/core/RigctlProtocol.cppsrc/core/RigctlProtocol.hGenerated by AetherClaude (automated agent for AetherSDR)