Skip to content

Revert "[fix] Frameless floating windows: resize, state persistence, geometry (#2008)"#2042

Merged
ten9876 merged 1 commit into
mainfrom
auto/Revert-fix-Frameless-floating-windows-resize-state
Apr 26, 2026
Merged

Revert "[fix] Frameless floating windows: resize, state persistence, geometry (#2008)"#2042
ten9876 merged 1 commit into
mainfrom
auto/Revert-fix-Frameless-floating-windows-resize-state

Conversation

@ten9876

@ten9876 ten9876 commented Apr 26, 2026

Copy link
Copy Markdown
Collaborator

Reverts #2008.

The frameless-window changes regressed input handling in the Aetherial Audio container — multiple applets (knobs, chain-tile drag-to-reorder, etc.) stopped responding correctly to mouse events after the merge. Likely cause is the new FramelessResizer recursively installing its event filter on every descendant widget and capturing events that inner controls needed.

Backing out so we can investigate and ideally re-land the four fixes in smaller, isolated PRs:

  1. Frameless mode propagation to child windows ✓ low-risk, can re-land standalone
  2. Floating-pan state persistence ✓ low-risk
  3. Floating-applet state persistence ✓ low-risk
  4. Geometry-format migration ✓ low-risk
  5. FramelessResizer — needs scope tightened (event filter on the window only, not all children) before re-landing

Original PR by @chibondking — see #2008 for the breakdown.

@ten9876 ten9876 requested a review from jensenpat as a code owner April 26, 2026 18:18
@ten9876 ten9876 enabled auto-merge (squash) April 26, 2026 18:18
@ten9876 ten9876 merged commit daf0b58 into main Apr 26, 2026
4 checks passed
@ten9876 ten9876 deleted the auto/Revert-fix-Frameless-floating-windows-resize-state branch April 26, 2026 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant