Fix Autotune label leaking to non-CW modes and show marker row always#1620
Merged
ten9876 merged 1 commit intoApr 18, 2026
Merged
Conversation
Two small VFO flag fixes on top of #1614/#1615: 1. The CW autotune row ("Autotune:" label + Once/Loop/Zero Beat buttons) was built inside a QWidget container and added to the filter grid, but only the buttons were tracked as members for cleanup — the container itself was leaked on rebuild. Switching away from CW left the "Autotune:" label visible under USB/AM/FM. Track the container as m_autotuneContainer and delete it at the top of rebuildFilterButtons; its children (label + buttons) get reaped with it. 2. The Thin/Thick/Edges/Hide marker-style row was previously restricted to CW/CWL (#1615). Narrow filters aren't CW-exclusive (DIGL, RTTY, CWL at narrow widths all cluster the edges the same way) and the per-slice setting is useful regardless of mode. Drop the CW-only gate. The same single code path in rebuildFilterButtons now runs for every mode — no per-mode duplication, just existing pointer members reinitialized on each mode change, cleanup still suppresses duplicate rows. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small VFO flag fixes on top of #1614/#1615:
The CW autotune row ("Autotune:" label + Once/Loop/Zero Beat
buttons) was built inside a QWidget container and added to the
filter grid, but only the buttons were tracked as members for
cleanup — the container itself was leaked on rebuild. Switching
away from CW left the "Autotune:" label visible under USB/AM/FM.
Track the container as m_autotuneContainer and delete it at the
top of rebuildFilterButtons; its children (label + buttons) get
reaped with it.
The Thin/Thick/Edges/Hide marker-style row was previously
restricted to CW/CWL (Restrict VFO marker-style buttons to CW/CWL modes and clean up on rebuild #1615). Narrow filters aren't CW-exclusive
(DIGL, RTTY, CWL at narrow widths all cluster the edges the same
way) and the per-slice setting is useful regardless of mode.
Drop the CW-only gate. The same single code path in
rebuildFilterButtons now runs for every mode — no per-mode
duplication, just existing pointer members reinitialized on each
mode change, cleanup still suppresses duplicate rows.
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com