Propagate late-arriving DIV eligibility to all VFOs (#1503)#1613
Merged
ten9876 merged 1 commit intoApr 18, 2026
Merged
Conversation
If the radio's model status arrives after Slice A is created, onSliceAdded reads an empty m_radioModel.model() and permanently hides the Diversity button on that VfoWidget. Later slices succeed because model info is available by then. Identical race pattern to the SmartSDR+ subscription issue fixed in #1356. Extend the existing infoChanged handler — which already iterates every VfoWidget for SmartSDR+ — to also re-apply setDiversityAllowed using the dual-SCU model list. Deterministic regardless of protocol message ordering; Linux tends to dodge the race via TCP arrival ordering but Windows reliably trips it. Closes #1503. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the radio's model status arrives after Slice A is created,
onSliceAdded reads an empty m_radioModel.model() and permanently
hides the Diversity button on that VfoWidget. Later slices succeed
because model info is available by then. Identical race pattern
to the SmartSDR+ subscription issue fixed in #1356.
Extend the existing infoChanged handler — which already iterates
every VfoWidget for SmartSDR+ — to also re-apply setDiversityAllowed
using the dual-SCU model list. Deterministic regardless of protocol
message ordering; Linux tends to dodge the race via TCP arrival
ordering but Windows reliably trips it.
Closes #1503.
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com