Fix WSJT-X DT drift on DAX RX audio after TX cycles (#537)#1340
Closed
aethersdr-agent[bot] wants to merge 1 commit into
Closed
Fix WSJT-X DT drift on DAX RX audio after TX cycles (#537)#1340aethersdr-agent[bot] wants to merge 1 commit into
aethersdr-agent[bot] wants to merge 1 commit into
Conversation
Linux (PipeWireAudioBridge): Add silence fill during TX. Previously, feedDaxAudio() returned immediately when transmitting, causing the named pipe to underrun and creating a timing gap equal to the TX duration. Now a QTimer feeds elapsed-time-based silence samples to keep the pipe-source clock advancing in real-time. macOS (VirtualAudioBridge): Replace fixed 960-sample silence fill with QElapsedTimer-based sample counting. The old code wrote exactly 20ms of silence per QTimer tick regardless of actual elapsed time, causing cumulative drift from timer jitter across TX cycles. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2 tasks
Collaborator
|
Test report: I merged the drift fix PR #537 with main (v0.8.12.1 base) and tested it quite a bit on macOS Tahoe 26.4. It is not fixed. I am seeing high FT8 DTs after any initial transmit, including using the "test PTT" button. I'm on wired 2.5Gb ethernet. Using TCP CAT and DAX on a wsjtx improved 3.1 derivative. DT ends up near 2 seconds. I am using a GPSDO with 1PPS discipline for NTP on my network. |
Collaborator
|
Taking via rebased branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #537
What was changed
Fix WSJT-X DT drift on DAX RX audio after TX cycles (#537)
Files modified
src/core/PipeWireAudioBridge.cppsrc/core/PipeWireAudioBridge.hsrc/core/VirtualAudioBridge.cppsrc/core/VirtualAudioBridge.hGenerated by AetherClaude (automated agent for AetherSDR)