CI Build Failure Analysis

Hey! Thanks for working on fixing macOS popout panadapters — great set of improvements here. The CI build failure is a conditional compilation issue, not a problem with your logic.

What failed

Both the build and analyze (cpp) jobs fail at the Build step. The root cause is the sw->releaseResources() call added in src/gui/PanadapterStack.cpp:

static void refreshAfterReparent(AetherSDR::SpectrumWidget* sw)
{
    if (!sw) return;
    sw->releaseResources();  // ← compile error when AETHER_GPU_SPECTRUM is OFF
    sw->update();
}

Why it fails

SpectrumWidget::releaseResources() is only declared when AETHER_GPU_SPECTRUM is enabled (see src/gui/SpectrumWidget.h:333-336):

#ifdef AETHER_GPU_SPECTRUM
    void initialize(QRhiCommandBuffer* cb) override;
    void render(QRhiCommandBuffer* cb) override;
    void releaseResources() override;
#else
    void paintEvent(QPaintEvent* event) override;
#endif

The CI container (ghcr.io/ten9876/aethersdr-ci:latest) runs Ubuntu 24.04, which ships Qt 6.4.x. Since AETHER_GPU_SPECTRUM requires Qt 6.7+ (see CMakeLists.txt:194), it gets automatically disabled in CI. Without that define, SpectrumWidget inherits from plain QWidget, which has no releaseResources() method — hence the compile error.

How to fix

Wrap the releaseResources() call in the same preprocessor guard, in src/gui/PanadapterStack.cpp:

static void refreshAfterReparent(AetherSDR::SpectrumWidget* sw)
{
    if (!sw) return;
#ifdef AETHER_GPU_SPECTRUM
    sw->releaseResources();  // tear down old GPU surface
#endif
    sw->update();            // triggers repaint (or initialize() on GPU path)
}

Summary

This is a CI environment issue (Qt version mismatch), not a logic bug in your code. The fix on macOS (where GPU spectrum is typically enabled) is correct — it just needs the #ifdef guard so it also compiles on the CI's older Qt. The rest of your changes (slice title in window titles, extended ABCDEFGH labels, maximize signal wiring, layout invalidation on dock) all look clean.

— AetherClaude 🤖

CI Build Failure Analysis

The build and analyze (cpp) jobs both failed at the Build step. Here's what happened:

Root Cause: releaseResources() not available without GPU spectrum

In src/gui/PanadapterStack.cpp, the refreshAfterReparent() helper now calls sw->releaseResources() unconditionally:

static void refreshAfterReparent(AetherSDR::SpectrumWidget* sw)
{
    if (!sw) return;
    sw->releaseResources();  // ← compile error when AETHER_GPU_SPECTRUM is OFF
    sw->update();
}

However, SpectrumWidget::releaseResources() is only declared when AETHER_GPU_SPECTRUM is enabled (src/gui/SpectrumWidget.h:333-336):

#ifdef AETHER_GPU_SPECTRUM
    void initialize(QRhiCommandBuffer* cb) override;
    void render(QRhiCommandBuffer* cb) override;
    void releaseResources() override;
#else
    void paintEvent(QPaintEvent* event) override;
#endif

The CI container (ghcr.io/ten9876/aethersdr-ci:latest) runs on Ubuntu with Qt 6.4, which auto-disables AETHER_GPU_SPECTRUM (requires Qt 6.7+, see CMakeLists.txt:194). So SpectrumWidget inherits from plain QWidget, which has no releaseResources() method → compilation error.

How to Fix

Guard the call in src/gui/PanadapterStack.cpp:

static void refreshAfterReparent(AetherSDR::SpectrumWidget* sw)
{
    if (!sw) return;
#ifdef AETHER_GPU_SPECTRUM
    sw->releaseResources();  // tear down old GPU surface
#endif
    sw->update();            // triggers initialize() on next frame
}

Everything else looks good

The other changes in this PR (slice title in floating window, slice ID range A–H, maximize signal, layout invalidation on dock) are all fine and don't touch any conditionally-compiled code. Only the one releaseResources() call needs the #ifdef guard.

This is a CI infrastructure mismatch, not a logic error — the code is correct for GPU-enabled builds. The CI container just happens to use an older Qt that takes the non-GPU path. Thanks for the thorough macOS popout fixes! 🛠️

Taking via rebased branch.