Fix TCI audio header length and mono TX handling (#1239)#1264
Merged
Conversation
2 tasks
Fix four bugs in TciServer causing TCI audio decode/encode failures:
1. buildAudioFrame(): set hdr.length to per-channel sampleCount instead
of totalFloats (frames × channels). TCI spec requires per-channel count;
the doubled value caused WSJT-X to overrun into opposite channel data.
2. onRxAudioReady() int16 stereo path: same fix — use audioFrames (per-
channel) instead of srcSamples (total) for hdr.length.
3. onBinaryMessage() TX path: detect mono vs stereo from payload size
relative to hdr.length. WSJT-X sends mono float32; treating it as
stereo halved the effective sample rate, shifting FT8 tone frequencies.
4. audio_stream_sample_type parsing: handle string format names
("float32", "int16") in addition to numeric values, since toInt()
silently returns 0 for non-numeric strings.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3c79ac9 to
55e366c
Compare
This was referenced Apr 14, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1239
Generated by AetherClaude (automated agent for AetherSDR)