[memory] Show full memory frequency in dialog#1132
Merged
ten9876 merged 1 commit intoApr 11, 2026
Conversation
Contributor
There was a problem hiding this comment.
Looks good — clean, minimal fix with no issues found.
The one-digit-to-six change is correct: frequencies stored in MHz need 6 decimal places to preserve Hz-level precision (e.g. 14.225000 instead of 14.225). The column sizing is fine — resizeColumnsToContents() at line 281 runs before the minimum-width clamp at line 282, so the wider string will be displayed without truncation.
No out-of-scope changes, no null pointer or resource leak risks. Thanks for the fix @jensenpat.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
The Memory dialog formatted frequencies with only 3 decimal places, which truncated the displayed MHz value and hid the last 3 digits.
Validation