Skip to content

Cleanup: stale #3029 issue references in code comments after #3034 #3047

Description

@ten9876

Background

PR #3034 (just merged) added comments in two places in `src/gui/MainWindow.cpp` that reference `(#3029)`. That reference is wrong — #3029 was an unrelated PR (FlexControl wheel tuning by @rfoust) that merged earlier the same night. The panadapter-prime fix has no linked issue; the comments should either reference the PR that introduced them (#3034) or have the issue reference removed.

Affected lines (post-merge)

Two new comment blocks in `src/gui/MainWindow.cpp` introduced by PR #3034:

  1. In the `panadapterAdded` "existing applet" branch (around line 2837-2840):

    // Prime the spectrum widget with the pan's current dBm range on
    // reconnect so the noise-floor auto-adjust starts from the correct
    // position. (#3029)
    sw->setDbmRange(pan->minDbm(), pan->maxDbm());
  2. In `wirePanadapter()` (around line 11365-11372):

    // Prime the spectrum widget with the pan's current dBm range immediately
    // so the noise-floor auto-adjust starts from the correct position.
    // ...
    // correct radio-reported range via the pendingDbm guard. (#3029)
    sw->setDbmRange(pan->minDbm(), pan->maxDbm());

Proposed fix

Replace both `(#3029)` references with `(#3034)` — the PR that introduced these comments and is the meaningful reference for code archaeology purposes.

Why this is a follow-up, not a fix-up to #3034

Effort

~30 seconds. Single file, two single-character changes.

Eligibility

`aetherclaude-eligible` candidate — mechanical, well-bounded.

Metadata

Metadata

Assignees

No one assigned

    Labels

    GUIUser interfacedocumentationImprovements or additions to documentationenhancementImprovement to existing featuregood first issueGood for newcomersmaintainer-reviewRequires maintainer review before any action is taken

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions