Skip to content

TransmitModel::setMicLevel missing UI sync signal (same gap as #2083 was for VOX) #2180

Description

@ten9876

Background

PR #2084 (commit 90ea3051) fixed VOX setter UI sync by adding emit phoneStateChanged() to setVoxEnable, setVoxLevel, and setVoxDelay. Identified during code review of that PR.

The same gap exists in setMicLevel

TransmitModel::setMicLevel() does m_micLevel = level and emit commandReady(...) but does not emit a state-change signal. UI controls bound to mic level via the model state pattern won't update when the value changes via a path other than the slider itself (e.g. keyboard shortcut, MIDI controller, or radio echo).

Suggested fix

Same shape as #2084:

void TransmitModel::setMicLevel(int level)
{
    level = qBound(0, level, 100);
    m_micLevel = level;
    emit micStateChanged();
    emit commandReady(QString("transmit set miclevel=%1").arg(level));
}

Worth checking

A quick audit of all setters in src/models/TransmitModel.cpp would catch any other instances of this pattern (m_xxx = value + emit commandReady but no state-change signal).

Metadata

Metadata

Assignees

No one assigned

    Labels

    awaiting-responseWaiting for reporter to provide additional informationbugSomething isn't working

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions