Skip to content

[BUG] Crash if permission denied #112

@sjthespian

Description

@sjthespian

Describe the bug
I had a directory in my music collection with read permissions but without execute and it caused checkrr to crash.

time="2024-10-18T17:29:41-07:00" level=fatal msg="lstat /music/They Might Be Giants/The Pamphlet/wav/04 Fortnight.wav: permission denied /music/They Might Be Giants/The Pamphlet/wav"
❯ ls -l /media/mp3/They\ Might\ Be\ Giants/The\ Pamphlet
total 16532
-rw-rw-r-- 1 drich mp3 4429965 Nov 11  2021 '01 Helicopter of Elves.mp3'
-rw-rw-r-- 1 drich mp3 5782999 Nov 11  2021 '02 Buckle Down, Winsocki.mp3'
-rw-rw-r-- 1 drich mp3 3974464 Nov 11  2021 '03 There Will Be Sad.mp3'
-rw-rw-r-- 1 drich mp3 2708864 Nov 11  2021 '04 Fortnight.mp3'
drwxrwsr-x 1 drich mp3       0 Aug 23  2023  __MACOSX
-rw-rw-r-- 1 drich mp3   23819 Nov 11  2021  cover.jpg
drwxrwsr-- 1 drich mp3     246 Aug 23  2023  wav

To Reproduce
Steps to reproduce the behavior:

  1. Create a directory in your collection with permissions 0774
  2. Run the scanner and tail the log
  3. See it crash when it tries to read that directory

Expected behavior
While it should probably throw an error, it shouldn't crash.

Desktop (please complete the following information):

  • OS: MacOS
  • Browser: N/A
  • checkrr Version: 3.4.0

Additional context
FWIW, I'm probably not going to use checkrr to scan my music collection where it found this error. Several thousand of my mp3 files cannot be scanned by checker. For some reason it doesn't seem them as mp3 files. I wish there was a way to validate the magic number of files within the checkrr docker image. It doesn't have the file command, which is how I would normally do it. I'm not sure what the go module uses.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions