Severity: Info
Location: src/Servy.Manager/Resources/Strings.resx:186-200
Code:
<data name="Status_StartPending" xml:space="preserve">
<value>Start Pending</value> <!-- Has space -->
</data>
<data name="Status_StopPending" xml:space="preserve">
<value>StopPending</value> <!-- NO space -->
</data>
<data name="Status_ContinuePending" xml:space="preserve">
<value>Continue Pending</value> <!-- Has space -->
</data>
<data name="Status_PausePending" xml:space="preserve">
<value>PausePending</value> <!-- NO space -->
</data>
Explanation:
Four related status strings are shown to end users in the Manager UI. Two of them ("Start Pending", "Continue Pending") are written as two words, while the other two ("StopPending", "PausePending") are written as single camelCase-looking tokens. All four statuses are structurally the same concept (a pending state transition) and appear side-by-side in the same status column, so the inconsistency is visually jarring and looks like a typo to users.
These values mirror the ServiceControllerStatus enum names from the .NET BCL (which uses camelCase), but since the other two have been normalized to human-readable form, the two that weren't look like bugs. Any localization effort will also inherit this inconsistency unless fixed upstream.
Suggested fix:
<data name="Status_StopPending" xml:space="preserve">
<value>Stop Pending</value>
</data>
...
<data name="Status_PausePending" xml:space="preserve">
<value>Pause Pending</value>
</data>
If any of these values are also referenced in unit tests as hardcoded strings (related to #744), those assertions will need the same update.
Severity: Info
Location:
src/Servy.Manager/Resources/Strings.resx:186-200Code:
Explanation:
Four related status strings are shown to end users in the Manager UI. Two of them ("Start Pending", "Continue Pending") are written as two words, while the other two ("StopPending", "PausePending") are written as single camelCase-looking tokens. All four statuses are structurally the same concept (a pending state transition) and appear side-by-side in the same status column, so the inconsistency is visually jarring and looks like a typo to users.
These values mirror the
ServiceControllerStatusenum names from the .NET BCL (which uses camelCase), but since the other two have been normalized to human-readable form, the two that weren't look like bugs. Any localization effort will also inherit this inconsistency unless fixed upstream.Suggested fix:
If any of these values are also referenced in unit tests as hardcoded strings (related to #744), those assertions will need the same update.