Description
The value 15 appears as a timeout buffer in at least 5 locations without a named constant or comment explaining why 15 seconds was chosen:
src/Servy.Core/Helpers/ServiceHelper.cs:65-66
src/Servy.Core/Services/ServiceManager.cs:413,631,662
Similarly, 101 graph points in PerformanceViewModel.cs:207,353 and WaitChunkMs/ScmAdditionalTimeMs static fields in Service.cs:79,87-88 lack explanation.
Suggested fix
Define as named constants with explanatory comments:
/// <summary>Extra buffer to ensure SCM doesn't kill the service before cleanup finishes.</summary>
private const int ScmTimeoutBufferSeconds = 15;
Description
The value
15appears as a timeout buffer in at least 5 locations without a named constant or comment explaining why 15 seconds was chosen:src/Servy.Core/Helpers/ServiceHelper.cs:65-66src/Servy.Core/Services/ServiceManager.cs:413,631,662Similarly,
101graph points inPerformanceViewModel.cs:207,353andWaitChunkMs/ScmAdditionalTimeMsstatic fields inService.cs:79,87-88lack explanation.Suggested fix
Define as named constants with explanatory comments: