Description
The property name EnableRotation is used in two core types:
src/Servy.Core/Domain/Service.cs (line 99) — EnableRotationsrc/Servy.Core/DTOs/ServiceDto.cs (line 82) — EnableRotation
Meanwhile, InstallServiceOptions correctly uses the disambiguated name EnableSizeRotation (line 42). The CLI also has a deprecated --enableRotation flag alongside the new --enableSizeRotation, confirming this ambiguity was recognized but only partially addressed.
With date-based rotation (EnableDateRotation, DateRotationType) now being a feature, EnableRotation is ambiguous — a developer cannot tell whether it refers to size-based or date-based rotation.
Severity
Warning — naming ambiguity in core domain model.
Suggested fix
Rename to EnableSizeRotation in both Service.cs and ServiceDto.cs for consistency with InstallServiceOptions.
Description
The property name
EnableRotationis used in two core types:src/Servy.Core/Domain/Service.cs(line 99) —EnableRotationsrc/Servy.Core/DTOs/ServiceDto.cs(line 82) —EnableRotationMeanwhile,
InstallServiceOptionscorrectly uses the disambiguated nameEnableSizeRotation(line 42). The CLI also has a deprecated--enableRotationflag alongside the new--enableSizeRotation, confirming this ambiguity was recognized but only partially addressed.With date-based rotation (
EnableDateRotation,DateRotationType) now being a feature,EnableRotationis ambiguous — a developer cannot tell whether it refers to size-based or date-based rotation.Severity
Warning — naming ambiguity in core domain model.
Suggested fix
Rename to
EnableSizeRotationin bothService.csandServiceDto.csfor consistency withInstallServiceOptions.