Skip to content

Fix: bump google_fonts to use the new Flutter API to find fonts #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Marc-Andrieu merged 1 commit into from
Jan 11, 2026
Merged

Fix: bump google_fonts to use the new Flutter API to find fonts #636

Marc-Andrieu merged 1 commit into from
Jan 11, 2026

Conversation

@Marc-Andrieu
Copy link
Member

@Marc-Andrieu Marc-Andrieu commented Jan 11, 2026

Description

Summary

#635 raised Flutter's version to 3.38, which, according to the release notes, has the following breaking change:

Remove deprecated AssetManifest.json file by @matanlurey in 172594

But google_fonts 6.2.1 relied on this file, until 6.3.0 where, according to the changelog, they:

Update AssetManifest to use the builtin Flutter API.

That's why google_fonts version ought to be bumped.

NB: 7.0.0 was released 4 days ago, without breaking changes according to the changelog, I decided to test it and it works as before #635

Changes Made

  • Use google_fonts 7.0.0

Additional Notes

Classification

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature)
  • 🔧 Infra CI/CD (changes to configs of workflows)
  • 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end)
  • 😶‍🌫️ No impact for the end-users: that's why an alpha was for: testing

Impact & Scope

  • Core functionality changes
  • Single module changes
  • Multiple modules changes
  • Other: dependency

Testing

  • 1. Tested this locally
  • 2. Added/modified tests that pass the CI (or tested in a downstream fork)
  • 3. Tested in a local client using a pre-prod backend
  • 0. Untestable (exceptionally), will be tested in prod directly

Documentation

  • Updated the docs accordingly :
  • // Comments
  • No documentation needed

@Marc-Andrieu Marc-Andrieu self-assigned this Jan 11, 2026
@Marc-Andrieu Marc-Andrieu added fix bug This PR fix a bug dependencies Pull requests that update a dependency file labels Jan 11, 2026
@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.35%. Comparing base (517fcc8) to head (057bdc0).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #636   +/-   ##
=======================================
  Coverage   51.35%   51.35%           
=======================================
  Files         167      167           
  Lines        3770     3770           
=======================================
  Hits         1936     1936           
  Misses       1834     1834

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Marc-Andrieu Marc-Andrieu merged commit cc72b0b into main Jan 11, 2026
8 checks passed
@Marc-Andrieu Marc-Andrieu deleted the fix/fonts branch January 11, 2026 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julien4215 julien4215 julien4215 approved these changes

@Luhmos Luhmos Luhmos approved these changes

Assignees

@Marc-Andrieu Marc-Andrieu

Labels

dependencies Pull requests that update a dependency file fix bug This PR fix a bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Marc-Andrieu @codecov-commenter @julien4215 @Luhmos