Closed
Conversation
armanddidierjean
requested changes
Jul 19, 2025
Comment on lines
+684
to
+688
| # We need to make sur the user will keep the same school if he is not a no_school user | ||
| _, new_school_id = await get_account_type_and_school_id_from_email( | ||
| email=mail_migration.new_email, | ||
| db=db, | ||
| ) |
Member
There was a problem hiding this comment.
Do we really want to change the school?
|
|
||
| # The email column should not be unique. | ||
| # Someone can indeed create more than one password reset request, | ||
| email: Mapped[str] |
Member
There was a problem hiding this comment.
Allowing multiple request for a same user improve considerably the user experience
Comment on lines
-784
to
+813
| return "The email address has been successfully updated" | ||
| return standard_responses.Result() |
Member
There was a problem hiding this comment.
We should use a CalypSSO page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changed mail migration and recover to harmonize both and to prevent duplicate tokens
⚠️ Consider changing CalypSSO mail for mail-migration-already-exist :
Which is sent to the holder of the new address (to prevent anyone from extracting emails), but doesnt make sense for him
Checklist