Fix OpenAPI specs#390
Merged
julien4215 merged 11 commits intomainfrom Apr 28, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #390 +/- ##
==========================================
+ Coverage 80.43% 80.45% +0.02%
==========================================
Files 85 85
Lines 5790 5797 +7
==========================================
+ Hits 4657 4664 +7
Misses 1133 1133 ☔ View full report in Codecov by Sentry. |
julien4215
requested changes
Apr 10, 2024
julien4215
reviewed
Apr 11, 2024
Contributor
julien4215
left a comment
There was a problem hiding this comment.
Why are we moving versions numbers and code to .env ? (see Armand's comment below)
In my opinion these fields should be hardcoded and not based on the dotenv. The MINIMAL_TITAN_VERSION_CODE is known during development and not deployement.
dec3a49 to
ae5e734
Compare
armanddidierjean
approved these changes
Apr 27, 2024
Member
armanddidierjean
left a comment
There was a problem hiding this comment.
Brilliant, thanks @Petitoto!
julien4215
approved these changes
Apr 27, 2024
This reverts commit ee3a5bc. # Conflicts: # app/utils/auth/providers.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes OpenAPI specs, with the aim to be fully compatible with several API clients like Hoppscotch.
This includes:
/(see https://learn.openapis.org/specification/paths.html#the-endpoints-list)^[a-zA-Z0-9\.\-_]+$(see https://spec.openapis.org/oas/latest.html#fixed-fields-5)HYPERION_VERSIONandMINIMAL_TITAN_VERSION_CODEto .envChecklist
Breaking change
Remove
PostmanAuthClient