fix(elevation): share config and fix paste when relaunched as admin#75
Merged
fix(elevation): share config and fix paste when relaunched as admin#75
Conversation
…n macOS/Linux
When the app relaunches as root via osascript (macOS) or pkexec (Linux),
app.getPath('userData') resolves to root's home directory, causing a
separate config to be used. Pass --kudu-data-dir to the elevated process
so it shares the original user's config. Also extend --no-sandbox to
macOS root to fix broken clipboard/paste shortcuts.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes two bugs when relaunching as admin on macOS (and Linux):
--no-sandboxChromium flag from Linux-only to also cover macOS root, restoring clipboard/Cmd+V functionality in the elevated process.--kudu-data-dir=<path>to the elevated process so it callsapp.setPath('userData', ...)on startup, ensuring it reads/writes the original user's config instead of/var/root/....LOG_DIRand related constants inlogger.tsfrom eager top-level evaluation to lazy getters, so theuserDataoverride takes effect before any path is resolved.Why?
When the app relaunches as root via
osascript(macOS) orpkexec(Linux),app.getPath('userData')resolves to root's home directory. This causes a fresh config to be used and, on macOS, Chromium's sandbox prevents clipboard access.How to test
Checklist
npm testpassesnpm run buildsucceeds