fix(ui): show real-time progress during cleaner clean operation#72
Merged
fix(ui): show real-time progress during cleaner clean operation#72
Conversation
The clean operation deleted files silently with no progress events, causing the progress bar to freeze near 100% until all deletions completed. Add throttled progress reporting to cleanItems() and all clean IPC handlers so the UI updates per-file during cleaning. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9c298e97cf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Progress denominator now uses only categories with selected items instead of all 7 categories, so partial cleans reach 100% correctly - Database optimizer emits progress even when a cached item ID is missing, preventing the bar from stalling below 100% Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onProgresscallback tocleanItems()that reports per-file progress as files are deletedSCAN_PROGRESSevents withphase: 'cleaning'so the UI updates in real-time with the current file path and progress percentageCleanerPageto distinguish scanning vs cleaning progress and initialize the progress bar immediately when cleaning startsTest plan
🤖 Generated with Claude Code