feat(darwin): comprehensive macOS platform improvements#71
Merged
Conversation
Fix multiple macOS-specific issues: standalone file dialogs instead of broken sheet mode, Dock icon visibility when relaunched as root, clipboard shortcuts via Edit menu, app size calculation with du, batched elevation prompts, ALF daemon restart after firewall changes, core dump check via sysctl, TCC access pre-check in large file finder, scanning progress UI fixes, threat monitor auto-refresh, and sidebar feature gating for drivers. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 148ee03ea0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Keep the default appMenu role (Quit, Hide, About, etc.) instead of replacing the entire application menu with only an Edit submenu. This restores Cmd+Q and Cmd+H which were inadvertently removed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
du -skto compute real installed app sizes in the debloater (batched in groups of 50)elevatedBatch()helper combines multiple admin commands into a single macOS password dialoglaunchctl limittosysctl kern.coredumpfor more reliable detectionTest plan
commands.test.tswith tests fordu-based size calculation,dufailure handling, and partial output parsingelevatedBatch(Chrome/Firefox telemetry toggles)🤖 Generated with Claude Code