fix: patch 4 high-severity bugs from codebase review#65
Merged
Conversation
- fix(file-utils): use platform-aware path separator in isExcluded so exclusion matching works on Linux/macOS (was hardcoded to backslash) - fix(cloud-agent): add DNS rebinding protection to blacklist download by calling assertPublicResolution before fetching the URL - fix(service-manager): support Automatic/AutomaticDelayed start types instead of silently falling back to Disabled - fix(index): prepend UTF-16LE BOM to schtasks XML so Windows Task Scheduler correctly parses the file Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2b77c88150
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isExcluded()hardcoded path normalization to backslash (\), completely breaking exclusion matching on Linux and macOS where/is the path separator. Now uses platform-aware separator.handleUpdateThreatBlacklistvalidated the URL hostname for private IP literals but never calledassertPublicResolution()to check DNS resolution, leaving a DNS rebinding SSRF vector. Now calls the existingassertPublicResolution()before downloading.applyServiceChangesonly allowedManualorDisabledstart types — any request to restore a service toAutomaticorAutomaticDelayedwas silently downgraded toDisabled. Now supports all 4 valid start types via an allowlist.schtasks /Createexpects a BOM to correctly identify the encoding; without it, auto-launch registration can silently fail (especially with non-ASCII exe paths). Added\uFEFFBOM.Test plan
🤖 Generated with Claude Code