intersphinx xref physical types#223
Conversation
3264256 to
b58c44f
Compare
| - pip | ||
| - pip: | ||
| - -e .[docs] | ||
| - astropy @ git+https://github.com/astropy/astropy.git |
There was a problem hiding this comment.
need to figure out a better way of setting astropy >= 4.3
There was a problem hiding this comment.
Fine to pin this as is for now. I want to hold off on requiring astropy >= 4.3 until at least gala v1.5 (next release is v1.4, hopefully within the next few weeks). By then, 4.3 should be out and we can change this to astropy>=4.3
| sphinx-astrorefs | ||
| sphinx_automodapi | ||
| sphinx_astropy | ||
| sphinx_astropy @ git+https://github.com/nstarman/sphinx-astropy.git@intersphinx-xref-physical-types |
There was a problem hiding this comment.
TODO: change when PR merged.
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
25a161c to
4d51b7f
Compare
|
Thanks for starting on this! I updated the conf.py in #243 and think this PR isn't necessary any more? But of course I still need to go through and update all of the physical type specifications in the docstrings... Let me know if you disagree and we can re-open this! |
|
Agreed. #243 does exactly what of sphinx-astropy intends. The only thing is that sphinx-astropy needs to be >= v1.4 |
Signed-off-by: Nathaniel Starkman (@nstarman) nstarkman@protonmail.com
Describe your changes
Ahh. This solution will require astropy v4.3+ for the physical types.
I'll get back to this later, when I update my PR to sphinx-astropy.Done. Now need to get RTD to compile with astropy v4.3. hmm.... any suggestions?without building RTD in astropy v4.3+, the links are not live. https://gala-astro--223.org.readthedocs.build/en/223/Current state : Gala doesn't work with astropy dev #222
Checklist
CHANGES.rst)Requires: #224