fix infinite recursion#11
Merged
adrn merged 1 commit intoJun 11, 2017
Merged
Conversation
turns out there were *two* problems: self._representation was being used instead of self.representation (which initializes an absent _representation), and self._data.differential was failing when _data was None or differentials were absent
Owner
|
thanks!! |
Owner
|
@eteq Oops, this didn't actually fix the recursion...but I just figured it out! The offending line turns out to be: calling |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
turns out there were two problems:
representation_component_nameswas changed to doself._representationinstead ofself.representation. That doesn't work becauseself.representationinitializes an absent _representation.self._data.differentialwas failing when_datawas None ordifferentialswere absent