feat(postprocessor): rewrite OwlBot PR title and body commits to include scope#6
Merged
Conversation
… untested with multiple files changed in a single commit
…genGapicConfigs to find correct package name
…aging to .gitignore
codyoss
reviewed
Dec 9, 2022
codyoss
reviewed
Dec 9, 2022
codyoss
requested changes
Dec 9, 2022
0eb667e to
f0b74df
Compare
f0b74df to
37caa90
Compare
adrianajg
commented
Dec 13, 2022
adrianajg
left a comment
Owner
Author
There was a problem hiding this comment.
Addressed changes and did some refactoring. Ready for additional feedback!
codyoss
reviewed
Dec 14, 2022
codyoss
left a comment
Collaborator
There was a problem hiding this comment.
Did a deeper review this time so this should be the last one. Thanks for the changes :)
adrianajg
commented
Dec 14, 2022
adrianajg
left a comment
Owner
Author
There was a problem hiding this comment.
A couple of loose ends still, let me know your thoughts please. Thanks!
codyoss
reviewed
Dec 14, 2022
Collaborator
|
@adrianajg It looks like you still have some failing vet tests. I think most(maybe all), would be fixed if you have format on save on. |
codyoss
approved these changes
Dec 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
api-namefeature in.OwlBot.yamlto set all square-bracketed scopes inserted by OwlBot to[REPLACEME][REPLACEME]substrings in PR title and body, use correspondingSource-LinkURLs ofgoogleapis/googleapis/commits to extract commit hash, then find scope by analyzing files changed in that commitNote: Does not yet update open PR as container lacks necessary credentials