Skip to content

feat(postprocessor): integrate OwlBot locally and add basic post-processor to copy generated code into libraries#1

Merged
adrianajg merged 9 commits into
Postprocessorfrom
OwlBot
Oct 26, 2022
Merged

feat(postprocessor): integrate OwlBot locally and add basic post-processor to copy generated code into libraries#1
adrianajg merged 9 commits into
Postprocessorfrom
OwlBot

Conversation

@adrianajg

Copy link
Copy Markdown
Owner

Create .github/.OwlBot.yaml and .github/.OwlBot.lock.yaml files

  • Invoking OwlBot locally copies generated code into specified destination directory: owl-bot-staging/

Create basic post-processor

  • Invoking post-processor locally copies code from owl-bot-staging/ into respective libraries and performs go mod tidy and gofmt -sdwl . on each directory

@adrianajg adrianajg requested a review from codyoss October 19, 2022 16:39
@adrianajg adrianajg marked this pull request as ready for review October 19, 2022 16:40
Comment thread .github/.OwlBot.yaml Outdated

@codyoss codyoss left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks just, just a handful of small cleanup stuff.

Comment thread .github/.OwlBot.lock.yaml Outdated
Comment thread internal/postprocessor/Dockerfile
Comment thread internal/postprocessor/go.mod Outdated
Comment thread internal/postprocessor/main.go Outdated
Comment thread internal/postprocessor/main.go Outdated
Comment thread internal/postprocessor/main.go Outdated
Comment thread internal/postprocessor/main.go Outdated
Comment thread internal/postprocessor/main.go Outdated
Comment thread internal/postprocessor/main.go Outdated
Comment thread internal/postprocessor/main.go Outdated
@adrianajg adrianajg requested a review from codyoss October 26, 2022 13:48

@codyoss codyoss left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple more small things

Comment thread internal/postprocessor/Dockerfile Outdated
Comment thread internal/postprocessor/execv/command.go Outdated
Comment thread internal/postprocessor/execv/gocmd/gocmd.go Outdated
Comment thread internal/postprocessor/main.go Outdated
Comment thread internal/postprocessor/main.go
@adrianajg adrianajg requested a review from codyoss October 26, 2022 15:35
Comment thread .github/.OwlBot.lock.yaml Outdated
@@ -0,0 +1,4 @@
docker:

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you still have these files checked in. An easy way to fix is comment out line in gitignore, delete them temp, uncomment gitignore, readded them for yourself locally.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't tell -- does it look like I fixed it?

@codyoss codyoss left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@adrianajg adrianajg merged commit f9762d0 into Postprocessor Oct 26, 2022
@adrianajg adrianajg deleted the OwlBot branch October 26, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants