Fix GSUB vkna substitution#4
Merged
hatchzo merged 2 commits intoadobe-type-tools:masterfrom Jan 25, 2021
Merged
Conversation
The GSUB `vkna` substitutions from CID+16333-CID+16349 (full-width Kana vertical glyphs) to CID+16395-CID+16411 (full-width Kana tuned for vertical writing glyphs) were missing. This commit adds them.
If the GSUB `vkna` substitution is used together with the GSUB `vert` substitution, CID+16236-CID+16252 in `vkna` are not used because they are substituted to other CIDs by `vert`. This commit removes them.
|
This request is acceptable. I think this issue will affect not only Adobe-Japan1-7 GSUB files but also Adobe-Japan1-5 and higher. I will double-check which files have impacts carefully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If I understand correctly, the full-width tuned for vertical writing Kana CIDs can be obtained by applying the GSUB substitution both
vertandvknato full-width horizontal Kana CIDs.e.g.
For U+30A1
ァ'KATAKANA LETTER SMALL A', CID+925 is full-width horizontal Kana CID.GSUB
vertsubstitution in aj17-gsub-jp04.fea says the following.Then, GSUB
vknasubstitution in aj17-gsub-jp04.fea says the following.The substitution result, CID+12548 is full-width tuned for vertical writing Kana CID.
However, GSUB
vknasubstitutions do not contain CID+16333-CID+16349 full-width vertical Kana CIDs.Therefore, applying GSUB substitution both
vertandvknato the full-width horizontal Kana, CID+16236-CID+16252, does not obtain the full-width tuned for vertical writing Kana CIDs.e.g.
For U+31F0
ㇰ'KATAKANA LETTER SMALL KU', CID+16236 is Kana full-width horizontal CID.GSUB
vertsubstitution in aj17-gsub-jp04.fea says the following.But, GSUB
vknasubstitution in aj17-gsub-jp04.fea does not contain CID+16333.Then, the substitution result, CID+16333 is not full-width tuned for vertical writing Kana CID.
The correct result is CID+16395 that is full-width tuned for vertical writing Kana CID.
This pull request adds GSUB
vknasubstitutions like the following.So the substitution result will be correct CID+16395.