Skip to content

update @adobe/asset-compute-sdk to latest version 2.2.1#86

Merged
moritzraho merged 1 commit intoadobe:masterfrom
jdelbick:update-asset-compute-sdk
Jul 22, 2020
Merged

update @adobe/asset-compute-sdk to latest version 2.2.1#86
moritzraho merged 1 commit intoadobe:masterfrom
jdelbick:update-asset-compute-sdk

Conversation

@alexkli
Copy link
Copy Markdown
Contributor

@alexkli alexkli commented Jul 22, 2020 •
edited
Loading

For the asset-compute action generator.

Release: https://github.com/adobe/asset-compute-sdk/releases/tag/v2.2.1

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@alexkli
Copy link
Copy Markdown
Contributor Author

alexkli commented Jul 22, 2020

@purplecabbage @moritzraho FYI

@alexkli alexkli mentioned this pull request Jul 22, 2020
Merged
8 tasks
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 22, 2020 •
edited
Loading

Codecov Report

Merging #86 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #86   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        22    +2     
  Lines          334       376   +42     
  Branches        42        47    +5     
=========================================
+ Hits           334       376   +42
Impacted Files Coverage Δ
generators/add-action/index.js 100.00% <ø> (ø)
generators/add-web-assets/exc-react/index.js 100.00% <ø> (ø)
generators/app/index.js 100.00% <ø> (ø)
lib/constants.js 100.00% <ø> (ø)
generators/add-action/asset-compute/index.js 100.00% <100.00%> (ø)
generators/delete-action/index.js 100.00% <100.00%> (ø)
generators/delete-events/index.js 100.00% <100.00%> (ø)
generators/delete-web-assets/index.js 100.00% <100.00%> (ø)
lib/ActionGenerator.js 100.00% <100.00%> (ø)
lib/utils.js 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b218c57...c2e9afe. Read the comment docs.

@moritzraho
Copy link
Copy Markdown
Member

moritzraho commented Jul 22, 2020

Hi Alex thanks LGTM
the caret in the version should already pick up latest minors and patch versions, but it's also fine to make it explicit

@moritzraho moritzraho merged commit d5821f4 into adobe:master Jul 22, 2020
@alexkli alexkli deleted the update-asset-compute-sdk branch July 22, 2020 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexkli @moritzraho