Low level API fixes (MOB-21261, MOB-21262, MOB-21447, and MOB-21460)#64
Merged
rymorale merged 3 commits intoadobe:dev-v3.0.1from Aug 7, 2024
Merged
Low level API fixes (MOB-21261, MOB-21262, MOB-21447, and MOB-21460)#64rymorale merged 3 commits intoadobe:dev-v3.0.1from
rymorale merged 3 commits intoadobe:dev-v3.0.1from
Conversation
MOB-21447: replaces the heads up notification (HUD) on API 21 with the expanded push template as the heads up notification is not expandable. additionally, the heads up notification is replaced by the collapsed layout on API22 and 23 as the HUD notification is expandable but does not show any title or body text. MOB-21261: use the `setOnlyAlertOnce` on the NotificationCompat.Builder to prevent an interaction intent from creating a new notification each time a push template interaction occurs. MOB-21262: use a expanded layout with a smaller image area to allow the notification action buttons to be displayed on the bottom of each notification.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-v3.0.1 #64 +/- ##
================================================
+ Coverage 91.20% 91.24% +0.04%
- Complexity 282 287 +5
================================================
Files 38 38
Lines 1865 1874 +9
Branches 173 176 +3
================================================
+ Hits 1701 1710 +9
Misses 101 101
Partials 63 63
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
code/notificationbuilder/src/main/res/layout/push_template_expanded_api23.xml
Show resolved
Hide resolved
spoorthipujariadobe
approved these changes
Aug 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves various issues specific to API23 and below.
MOB-21447: replaces the heads up notification (HUD) on API 21 with the expanded push template as the heads up notification is not expandable. On API 23 and 22, the heads up notification is replaced by the collapsed layout as the HUD notification is expandable but does not show any title or body text.
API21-23 HUD notification prior to fix:
API21 HUD notification after fix:
API23 HUD notification after fix:
MOB-21262: use a expanded layout with a smaller image area to allow the notification action buttons to be displayed on the bottom of each notification.
API21-23 notification image size prior to fix:
API21-23 notification image size after fix:
MOB-21261: use the
setOnlyAlertOnceon the NotificationCompat.Builder to prevent an interaction intent from creating a new notification each time a push template interaction occurs.MOB-21460: Throw a
NotificationConstructionFailedExceptionif attempting to build an Input Box notification on API23 or below. The feature was introduced in API24.Related Issue
https://jira.corp.adobe.com/browse/MOB-21261
https://jira.corp.adobe.com/browse/MOB-21262
https://jira.corp.adobe.com/browse/MOB-21447
https://jira.corp.adobe.com/browse/MOB-21460
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: