Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev-v5.0.0 #159 +/- ##
=============================================
Coverage ? 92.17%
=============================================
Files ? 25
Lines ? 2234
Branches ? 0
=============================================
Hits ? 2059
Misses ? 175
Partials ? 0 |
swarna04
reviewed
Mar 4, 2024
| } | ||
|
|
||
| class MockFloatingButton: FloatingButtonPresentable { | ||
| enum invocation { |
Contributor
There was a problem hiding this comment.
nit: enum/struct/class names should begin with an uppercase letter.
| return | ||
| } | ||
|
|
||
| state.previewButton?.dismiss() |
Contributor
There was a problem hiding this comment.
Should we dismiss showing the preview button before L175?
Contributor
Author
There was a problem hiding this comment.
The webview is not displayed if the network call to fetch the preview html fails. In this case the floating button can remain visible so we can retry preview selection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hide preview on device floating button when the webview is open to prevent clicking and recreating webview
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: