Added support for X-EXC-SDK & X-EXC-SDK-Version headers#148
Merged
swarna04 merged 2 commits intoadobe:dev-v4.0.2from Oct 11, 2023
Merged
Added support for X-EXC-SDK & X-EXC-SDK-Version headers#148swarna04 merged 2 commits intoadobe:dev-v4.0.2from
swarna04 merged 2 commits intoadobe:dev-v4.0.2from
Conversation
sbenedicadb
approved these changes
Aug 10, 2023
AEPTarget/Sources/Target.swift
Outdated
Comment on lines
+580
to
+582
| let sdkVersion = "\(coreVersion)+\(TargetConstants.EXTENSION_VERSION)" | ||
| return sdkVersion | ||
| } |
Member
There was a problem hiding this comment.
nit: just return without setting sdkVersion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
X-EXC-SDK -
AdobeTargetMobileX-EXC-SDK-Version - <Core+Target SDK version> e.g.
4.0.0+4.0.2Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: