Merged
Conversation
praveek
reviewed
Dec 18, 2023
| ## Requirements | ||
| - Xcode 14.1 (or newer) | ||
| - Xcode 15 (or newer) | ||
| - Swift 5.1 (or newer) |
Contributor
There was a problem hiding this comment.
Can you update this to latest version?
praveek
approved these changes
Jan 25, 2024
Contributor
|
Can you also remove the dependencies section from https://github.com/adobe/aepsdk-rulesengine-ios/blob/main/Package.swift#L11? |
praveek
approved these changes
Jan 25, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev-v5.0.0 #76 +/- ##
=============================================
Coverage ? 95.97%
=============================================
Files ? 17
Lines ? 472
Branches ? 0
=============================================
Hits ? 453
Misses ? 19
Partials ? 0 |
praveek
reviewed
Jan 25, 2024
praveek
approved these changes
Jan 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bumps the minimum deployment target to iOS 12 as per Xcode 15 requirements, and uses Xcode 15 in CI.