Add support for operand function types#48
Merged
sbenedicadb merged 6 commits intoadobe:dev-v1.1.0from Oct 4, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev-v1.1.0 #48 +/- ##
==============================================
- Coverage 95.92% 95.70% -0.22%
==============================================
Files 17 17
Lines 343 349 +6
==============================================
+ Hits 329 334 +5
- Misses 14 15 +1 |
| case none | ||
| case some(T) | ||
| case token(MustacheToken) | ||
| case function(() -> T) |
Contributor
There was a problem hiding this comment.
RulesEngine users can mix it up with another function case for MustachToken enum. Can we consider renaming it to computation?
| case let .token(mustache): | ||
| return "<Token: \(mustache)>" | ||
| case let .function(fun): | ||
| return "<Function: \(String(describing: fun.self))" |
Contributor
There was a problem hiding this comment.
Can we add a > to the end of the string?
yangyansong-adbe
approved these changes
Oct 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.