Skip to content

remove dynamic callable#44

Merged
shalehaha merged 2 commits intomainfrom
dev-v1.0.1
May 5, 2021
Merged

remove dynamic callable#44
shalehaha merged 2 commits intomainfrom
dev-v1.0.1

Conversation

@shalehaha
Copy link
Copy Markdown
Contributor

@shalehaha shalehaha commented May 4, 2021

Description

adobe/aepsdk-core-ios#589
@dynamicCallable is causing Swift compatibility issue

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link
Copy Markdown

codecov bot commented May 4, 2021

Codecov Report

Merging #44 (6687c3c) into main (1e27065) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #44   +/-   ##
=======================================
  Coverage   95.85%   95.85%           
=======================================
  Files          17       17           
  Lines         337      337           
=======================================
  Hits          323      323           
  Misses         14       14           

@shalehaha shalehaha requested a review from yangyansong-adbe May 4, 2021 15:53
@shalehaha shalehaha merged commit c3337be into main May 5, 2021
@shalehaha shalehaha added bug Something isn't working coresquad labels May 5, 2021
@praveek praveek deleted the dev-v1.0.1 branch March 2, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working coresquad

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants