-some cleanup in the rules engine#32
Merged
sbenedicadb merged 11 commits intoadobe:devfrom Jan 7, 2021
Merged
Conversation
dev > main
add beta language, update spm installation text
Dev to main
Co-authored-by: jgeng <jgeng@adobe.com>
Codecov Report
@@ Coverage Diff @@
## dev #32 +/- ##
======================================
Coverage ? 95.85%
======================================
Files ? 17
Lines ? 337
Branches ? 0
======================================
Hits ? 323
Misses ? 14
Partials ? 0 |
shalehaha
approved these changes
Jan 7, 2021
README.md
Outdated
| # for app development, include all the following pods | ||
| target 'YOUR_TARGET_NAME' do | ||
| pod 'AEPRulesEngine', :git => 'https://github.com/adobe/aepsdk-rulesengine-ios.git', :branch => 'main' | ||
| pod 'AEPCore', :git => 'https://github.com/adobe/aepsdk-core-ios.git', :branch => 'main' |
Contributor
There was a problem hiding this comment.
should only leave AEPRulesEngine here
README.md
Outdated
|
|
||
| ## Requirements | ||
| - Xcode 11.0 (or newer) | ||
| - Swift 5.0 (or newer) |
Contributor
There was a problem hiding this comment.
should be Swift 5.1
| /// The `Log` class will be dormant unless its static `logging` variable is initialized. | ||
| /// To enable logging from the RulesEngine, implement a class that conforms to the | ||
| /// `Logging` protocol and use an instance of it to set the `Log.logging` variable. | ||
| public enum Log { |
Contributor
There was a problem hiding this comment.
https://github.com/adobe/aepsdk-core-ios/blob/main/AEPServices/Sources/log/Log.swift
If we have import AEPRulesEngine and import AEPServices in the same class, it will make the "name conflicts" issue, so I think we'd better pick another name than Log.
| } | ||
|
|
||
| public enum RulesEngineLogLevel: Int, Comparable { | ||
| public enum LogLevel: Int, Comparable { |
Contributor
There was a problem hiding this comment.
the same concerns as Log class.
yangyansong-adbe
approved these changes
Jan 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.