Update configuration module to support media keys#91
Merged
yangyansong-adbe merged 3 commits intoadobe:mediafrom Oct 24, 2023
Merged
Update configuration module to support media keys#91yangyansong-adbe merged 3 commits intoadobe:mediafrom
yangyansong-adbe merged 3 commits intoadobe:mediafrom
Conversation
addb
reviewed
Oct 20, 2023
addb
reviewed
Oct 24, 2023
| m._media_configuration[key] = configuration[key] | ||
| end if | ||
| end for | ||
| channel = _adb_optStringFromMap(configuration, m._CONFIG_KEY.MEDIA_CHANNEL) |
Contributor
There was a problem hiding this comment.
Do you think we should add a method
optValidStringFromMap which will return either non empty string or invalid, so we dont need to check the string one more time.
this:
playerName = _adb_optStringFromMap(configuration,
m._CONFIG_KEY.MEDIA_PLAYER_NAME)
if not _adb_isEmptyOrInvalidString(playerName)
m._media_playerName = playerName
end if
becomes:
m._media_playerName = _adb_optValidStringFromMap(configuration, m._CONFIG_KEY.MEDIA_PLAYER_NAME)
Contributor
Author
There was a problem hiding this comment.
No, it won't work anyway. For example, in the case of overwriting the existing configuration, we still need to validate the existence of the media keys.
addb
approved these changes
Oct 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#100
The supported media config keys:
edgemedia.channeledgemedia.playerNameedgemedia.appVersion