Skip to content

Remove unused EdgeRequestQueue class#197

Merged
addb merged 5 commits intoadobe:consentfrom
addb:cleanup
Sep 11, 2024
Merged

Remove unused EdgeRequestQueue class#197
addb merged 5 commits intoadobe:consentfrom
addb:cleanup

Conversation

@addb
Copy link
Copy Markdown
Contributor

@addb addb commented Sep 10, 2024

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@addb addb requested a review from praveek September 10, 2024 18:52
@@ -68,7 +68,6 @@ governing permissions and limitations under the License.-->
<script type="text/brightscript" uri="pkg:/source/adobe/core/identityState.brs"/>
<script type="text/brightscript" uri="pkg:/source/adobe/edge/edgeModule.brs"/>
<script type="text/brightscript" uri="pkg:/source/adobe/edge/edgeRequest.brs"/>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice adding or removing a file requires changes to lot of other files. Can you add a task to automate this?

Copy link
Copy Markdown
Contributor Author

@addb addb Sep 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! 💯
#198

@addb
Copy link
Copy Markdown
Contributor Author

addb commented Sep 10, 2024

@praveek Improved makefile and version.sh script

Screenshot 2024-09-10 at 3 56 36 PM

@addb addb requested a review from praveek September 10, 2024 22:58
@addb addb requested a review from praveek September 10, 2024 23:28
@addb addb merged commit 374d4c6 into adobe:consent Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants