Merged
Conversation
…with edge module.
…he integration tests. Also added helpers to be used with the integration tests.
…y:result handle when Ecid is not cached with the SDK.
kevinlind
reviewed
Aug 31, 2024
…dentityRefactor
praveek
reviewed
Sep 4, 2024
code/main/task/eventProcessor.brs
Outdated
| m._edgeModule = _adb_EdgeModule(m._configurationModule, m._identityModule, m._consentState) | ||
| m._identityState = _adb_IdentityState() | ||
| m._edgeModule = _adb_EdgeModule(m._configurationModule, m._identityState, m._consentState) | ||
| m._identityModule = _adb_IdentityModule(m._identityState, m._edgeModule, m._task) |
There was a problem hiding this comment.
Instead of passing the task to the identity module, it would be cleaner to modify the getECID function to accept a callback. The function can then notify the task through the callback, so other modules don’t need to be aware of the task.
Contributor
Author
There was a problem hiding this comment.
@praveek sounds good. Updated to callbacks!
Contributor
Author
There was a problem hiding this comment.
@praveek Also fixed issues like:
- All the waiting callbacks will be called
- Callback map will be cleared once all callbacks are processed
Changes:
- (IdentityModule) getECIDAsync to get the response in callbacks
…sor to dispatch the event to task properly. Also need to publish sendEvent response to task since we support sendEventWithCallback.
praveek
reviewed
Sep 6, 2024
praveek
approved these changes
Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes in Identity
Edge Changes
Integration Test Changes
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: