Skip to content

Added logic to push resetIdentities event to all registered modules#190

Merged
addb merged 3 commits intoadobe:consentfrom
addb:handleResetIdentities
Sep 3, 2024
Merged

Added logic to push resetIdentities event to all registered modules#190
addb merged 3 commits intoadobe:consentfrom
addb:handleResetIdentities

Conversation

@addb
Copy link
Copy Markdown
Contributor

@addb addb commented Aug 27, 2024

Description

  • ResetIdentities Event is now passed to registered module.
  • LocationHint and state:store (edge module) need to be dropped along with the ECID (identity module)

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@addb addb linked an issue Aug 27, 2024 that may be closed by this pull request
Copy link
Copy Markdown

@kevinlind kevinlind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an additional test case which

  1. sets the location hint and state store
  2. calls resetIdentities
  3. sends a network request and verifies the request does not have the location hint and state store?

Your current test is good in that it verifies the delete function is called, but you should also verify the actual value is deleted.

@addb
Copy link
Copy Markdown
Contributor Author

addb commented Aug 29, 2024

Can you add an additional test case which

  1. sets the location hint and state store
  2. calls resetIdentities
  3. sends a network request and verifies the request does not have the location hint and state store?

Your current test is good in that it verifies the delete function is called, but you should also verify the actual value is deleted.

I will add the case for the steps you mentioned. For verifying it actually deleted, I believe stateStore and locationHint unit tests would have covered that. And can be covered in Integration tests.

@addb
Copy link
Copy Markdown
Contributor Author

addb commented Aug 29, 2024

Can you add an additional test case which

  1. sets the location hint and state store
  2. calls resetIdentities
  3. sends a network request and verifies the request does not have the location hint and state store?

Your current test is good in that it verifies the delete function is called, but you should also verify the actual value is deleted.

For verifying it actually deleted, I believe stateStore and locationHint unit tests would have covered that. And can be covered in Integration tests. Also the case you mentioned I will cover as a part of Integration tests.

@addb addb requested a review from kevinlind August 29, 2024 02:54
@addb addb merged commit 31419e2 into adobe:consent Sep 3, 2024
@addb addb deleted the handleResetIdentities branch September 5, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle Reset Identities for all modules

3 participants