Skip to content

Rearrange document and add API reference for setConsent API.#185

Merged
addb merged 7 commits intoadobe:consentfrom
addb:consentDoc
Sep 5, 2024
Merged

Rearrange document and add API reference for setConsent API.#185
addb merged 7 commits intoadobe:consentfrom
addb:consentDoc

Conversation

@addb
Copy link
Copy Markdown
Contributor

@addb addb commented Aug 12, 2024 •
edited by praveek
Loading

Description

  • Rearrange doc into separate section for readability
  • Add setConsent API reference with sample

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@addb addb linked an issue Aug 12, 2024 that may be closed by this pull request
Update Documentation and Sample app for Consent #168
Closed
@addb addb changed the title Rearrange document and add API reference for setConsent API. [WIP] [Do Not Merge] Rearrange document and add API reference for setConsent API. Aug 12, 2024
@addb addb changed the title [WIP] [Do Not Merge] Rearrange document and add API reference for setConsent API. Rearrange document and add API reference for setConsent API. Aug 13, 2024
praveek
praveek reviewed Aug 29, 2024
View reviewed changes
praveek
praveek reviewed Aug 29, 2024
View reviewed changes
praveek
praveek reviewed Sep 4, 2024
View reviewed changes
praveek
praveek reviewed Sep 4, 2024
View reviewed changes
praveek
praveek reviewed Sep 4, 2024
View reviewed changes
@addb addb requested a review from praveek September 5, 2024 00:34
praveek
praveek reviewed Sep 5, 2024
View reviewed changes
praveek
praveek reviewed Sep 5, 2024
View reviewed changes
praveek
praveek approved these changes Sep 5, 2024
View reviewed changes
Copy link
Copy Markdown

@praveek praveek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I just have a minor update to the comments.

@addb addb merged commit 28ca759 into adobe:consent Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@praveek praveek praveek approved these changes

@emdobrin emdobrin Awaiting requested review from emdobrin

@yangyansong-adbe yangyansong-adbe Awaiting requested review from yangyansong-adbe

@kevinlind kevinlind Awaiting requested review from kevinlind

@stcheng-adobe stcheng-adobe Awaiting requested review from stcheng-adobe

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Documentation and Sample app for Consent

3 participants

@addb @praveek @stcheng-adobe