Skip to content

Enforce consent#184

Merged
addb merged 17 commits intoadobe:consentfrom
addb:enforceConsent
Aug 27, 2024
Merged

Enforce consent#184
addb merged 17 commits intoadobe:consentfrom
addb:enforceConsent

Conversation

@addb
Copy link
Copy Markdown
Contributor

@addb addb commented Aug 12, 2024

Description

Edge Request Worker: Queue Processing

Screenshot 2024-08-23 at 12 22 56 PM

Consent: setConsent API flow

Screenshot 2024-08-26 at 5 52 00 PM

Consent Module working

Screenshot 2024-08-26 at 5 55 42 PM

Changes

  • Enforce consent in EdgeModule using consentState
  • Refactor EdgeRequestWorker to use EdgeRequest
  • Add EdgeRequest class
  • Add tests for Edge request and consent enforcement in EdgeRequestWorker
  • Update tests
  • Enforce consent in IdentityModule using consentState
  • Update and add tests for Identity

Extra changes

  • Use helpers in Media classes
  • logging improvements and cleanup
  • fix unused variables warning by prefixing '_'

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@addb addb linked an issue Aug 12, 2024 that may be closed by this pull request
addb added 3 commits August 22, 2024 13:51
…ts till the queue is blocked. If the queue is not blocked process the requests in order by comparing the ts of oldest hits in both the queues.
@addb addb requested review from kevinlind and praveek August 23, 2024 19:06
@addb addb linked an issue Aug 26, 2024 that may be closed by this pull request
@addb addb requested a review from praveek August 26, 2024 22:31
@addb addb requested a review from praveek August 26, 2024 22:58
@addb addb requested a review from praveek August 27, 2024 00:53
@addb addb merged commit d87345b into adobe:consent Aug 27, 2024
@addb addb deleted the enforceConsent branch September 5, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unblock Request Queue when consentState is pending Enforce Consent using ConsentStatus

3 participants