State store enhancement + code cleanup + string helpers + more tests#179
Merged
addb merged 9 commits intoadobe:consentfrom Jul 30, 2024
Merged
State store enhancement + code cleanup + string helpers + more tests#179addb merged 9 commits intoadobe:consentfrom
addb merged 9 commits intoadobe:consentfrom
Conversation
praveek
reviewed
Jul 30, 2024
kevinlind
approved these changes
Jul 30, 2024
kevinlind
left a comment
There was a problem hiding this comment.
I agree with Praveen's comment to rename _adb_ExpiryTime to _adb_Timer, but other than that this this looks good.
praveek
approved these changes
Jul 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: