Skip to content

Cleanup to avoid confusion and get ready for the datastream override feature#151

Merged
addb merged 1 commit intoadobe:datastreamOverridefrom
addb:datastreamOverride
Apr 22, 2024
Merged

Cleanup to avoid confusion and get ready for the datastream override feature#151
addb merged 1 commit intoadobe:datastreamOverridefrom
addb:datastreamOverride

Conversation

@addb
Copy link
Copy Markdown
Contributor

@addb addb commented Apr 18, 2024

  • Rename xdmData to eventData since now that contains xdm as well as freeform/non-xdm data and will also contain datastream override details in future.
  • Converting to list of xdm events in edgeRequestWorker where we create the payload.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Copy Markdown
Contributor

@yangyansong-adbe yangyansong-adbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@addb addb merged commit fca64d9 into adobe:datastreamOverride Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants