Update version to 1.1.0-alpha#119
Merged
yangyansong-adbe merged 2 commits intoadobe:mediafrom Nov 18, 2023
Merged
Conversation
addb
reviewed
Nov 17, 2023
addb
reviewed
Nov 17, 2023
sample/development/components/integration/test/integrationTests.brs
Outdated
Show resolved
Hide resolved
addb
reviewed
Nov 17, 2023
| ADB_assertTrue((debugInfo.configuration.media_channel = "channel_test"), LINE_NUM, "assert media_channel is valid") | ||
| ADB_assertTrue((debugInfo.configuration.media_playerName = "player_test"), LINE_NUM, "assert media_playerName is valid") | ||
| ADB_assertTrue((debugInfo.configuration.media_appVersion = "1.0.0"), LINE_NUM, "assert media_appVersion is valid") | ||
| ADB_assertTrue((debugInfo.configuration.media_appVersion = "1.1.0-alpha"), LINE_NUM, "assert media_appVersion is valid") |
Contributor
There was a problem hiding this comment.
can we have test-constant for this so we dont need to update the tests everywhere.
Contributor
Author
There was a problem hiding this comment.
I prefer to keep those raw values in tests. It's easy to update those values when bumping the SDK version, and it's obvious when checking the test code. Also, it's not straight forward to add a "constant" in Brightscript and to be referred to in multiple files.
addb
reviewed
Nov 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.